Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: amend order spam check is wrong #11516

Closed
ze97286 opened this issue Jul 31, 2024 · 0 comments · Fixed by #11517
Closed

[Bug]: amend order spam check is wrong #11516

ze97286 opened this issue Jul 31, 2024 · 0 comments · Fixed by #11517
Labels
bug

Comments

@ze97286
Copy link
Contributor

ze97286 commented Jul 31, 2024

Problem encountered

amend orders are rejected for now having sufficient margin although they do.

Observed behaviour

the order margin spam check for amends is wrong.

Expected behaviour

orders with sufficient margin should pass spam check.

Steps to reproduce

1. Submit `xyz` transaction
2. With this payload
3. Query `abc` API
4. Observe the error

Software version

develop

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response
@ze97286 ze97286 added the bug label Jul 31, 2024
@ze97286 ze97286 mentioned this issue Jul 31, 2024
Merged
@vega-issues vega-issues moved this to Waiting Review in Core Kanban Jul 31, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Jul 31, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Core Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: order spam check for amends fixed vegaprotocol/vega
1 participant
@ze97286