Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Tier number not populated #11646

Closed
3 tasks
JonRay15 opened this issue Sep 3, 2024 · 1 comment · Fixed by #11649
Closed
3 tasks

API: Tier number not populated #11646

JonRay15 opened this issue Sep 3, 2024 · 1 comment · Fixed by #11649

Comments

@JonRay15
Copy link

JonRay15 commented Sep 3, 2024

Summary

We requested to add a tier number to all "program" APIs.

{
  "data": {
    "currentVolumeRebateProgram": {
      "id": "c173a4b09efb119ce757c1bf0ed168d440a3db7e1c012f31108191d41330043c",
      "version": 1,
      "benefitTiers": [
        {
          "minimumPartyMakerVolumeFraction": "0.001",
          "additionalMakerRebate": "0.00001",
          "tierNumber": null
        },
        {
          "minimumPartyMakerVolumeFraction": "0.01",
          "additionalMakerRebate": "0.0001",
          "tierNumber": null
        },
        {
          "minimumPartyMakerVolumeFraction": "0.05",
          "additionalMakerRebate": "0.0005",
          "tierNumber": null
        }
      ],
      "endOfProgramTimestamp": "2024-10-03T14:30:29Z",
      "windowLength": 1,
      "endedAt": null
    }
  }
}

As you can see above it is null.... per feedback it looks like this is a GQL only problem as it is there on the REST.

Expected behaviour

  • When the program proposal is processed it the Core should sort the tiers into the correct order based on the relevant metric and then derive the tier number
  • If a proposal is uploaded that attempts to manually set the tier number it should fail validation
  • This should apply to volume discount programs, referral programs, and maker rebate programs
@JonRay15 JonRay15 moved this to Todo in Core Kanban Sep 3, 2024
@JonRay15 JonRay15 added this to the 🏯 Suzuka Castle milestone Sep 3, 2024
@JonRay15 JonRay15 added the fe-request A list of reasonably high value API change requests from front end label Sep 3, 2024
@vega-issues vega-issues moved this from Todo to Waiting Review in Core Kanban Sep 4, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Sep 4, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Sep 4, 2024
@JonRay15
Copy link
Author

JonRay15 commented Sep 9, 2024

Checked on FG for all three of volume discount, referral program, and volume maker rebate and they all look good.

@JonRay15 JonRay15 removed the fe-request A list of reasonably high value API change requests from front end label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant