-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trade API graphQL resolver not including new trade fees #11672
Labels
Comments
JonRay15
added
bug
fe-request
A list of reasonably high value API change requests from front end
labels
Sep 11, 2024
Maker rebate stll not on GQL.... I'm running this
Rest response - high volume maker fee :
GraphQL for the exact same trade - no maker fee 👎
|
Confirmed .... we have a high volume maker fee ...
|
JonRay15
removed
the
fe-request
A list of reasonably high value API change requests from front end
label
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Treasury fee
Buyback fee
High volume maker fee
Not working
Testing on BTC market
Here are all the trades
https://api.n00.testnet.vega.rocks/api/v2/trades?marketIds=07d83b233cc0c43b8e46b5384bbbb52bd23d27502c20ba180cfb9c690e0ba6be
My trade ID = c63dc855d8c4519220f76bb241d811976e3becb027243c0e6002e32d25e28908
REST API is returning tresury / buyback
"buyerFee": {
"makerFee": "1011904",
"infrastructureFee": "2529759",
"liquidityFee": "50596",
"makerFeeVolumeDiscount": "0",
"infrastructureFeeVolumeDiscount": "0",
"liquidityFeeVolumeDiscount": "0",
"makerFeeReferrerDiscount": "0",
"infrastructureFeeReferrerDiscount": "0",
"liquidityFeeReferrerDiscount": "0",
"treasuryFee": "1517856",
"buyBackFee": "505952",
"highVolumeMakerFee": "0"
But these are not appearing on the graphQL ... admitedly high volume maker fee is 0 here but in another trade I observed it missing ... take my word for it.
The text was updated successfully, but these errors were encountered: