Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: referral and volume discount programs not appearing in APIs #9741

Closed
cdummett opened this issue Oct 11, 2023 · 1 comment
Closed

[Bug]: referral and volume discount programs not appearing in APIs #9741

cdummett opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@cdummett
Copy link
Contributor

cdummett commented Oct 11, 2023

Problem encountered

Since #9719 market-sim tests have been failing due to proto changes.

After updating market-sim protos in vegaprotocol/vega-market-sim#524, tests are still failing as the APIs never show the updated programs.

The programs are enacted however as we can see discounts applied to trades.

Observed behaviour

  1. Proposal submitted and accepted by core
  2. Updated program does not appear in APIs 🔴

Expected behaviour

  1. Proposal submitted and accepted by core
  2. Updated program does appear in APIs 🟢

Steps to reproduce

1. cd vega-market-sim
1. git checkout gix/governance_protos
1. poetry shell
1. pytest tests/integration/test_trading.py::test_volume_discount_program

Software version

ae2715f

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@cdummett
Copy link
Contributor Author

Closing, as market-sim issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants