Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: recurring transfer for LP fees received not distributed #9746

Closed
cdummett opened this issue Oct 11, 2023 · 0 comments · Fixed by #9748
Closed

[Bug]: recurring transfer for LP fees received not distributed #9746

cdummett opened this issue Oct 11, 2023 · 0 comments · Fixed by #9748

Comments

@cdummett
Copy link
Contributor

cdummett commented Oct 11, 2023

Problem encountered

In market-sim reward pools being funded with a dispatch metric set to DISPATCH_METRIC_LP_FEES_RECEIVED do not seem to be paying out to LPs.

https://jenkins.vega.rocks/job/common/job/vega-market-sim-reinforcement/56/artifact/fuzz_plots/rewards.jpg

Feature test added in #9745 to test behaviour.

In test we can see a recurring transfer is successfully setup but an LP who receives fees through a TRANSFER_TYPE_LIQUIDITY_FEE_NET_DISTRIBUTE transfer still receives no rewards.

Test checks both entity_scope=ENTITY_SCOPE_INDIVIDUALS and entity_scope=ENTITY_SCOPE_TEAMS.

Observed behaviour

  1. LP commits liquidity and submits pegged orders to meet their commitment
  2. Market exits opening auction
  3. Recurring transfer setup to fund an ACCOUNT_TYPE_REWARD_LP_RECEIVED_FEES pool
  4. Trades generate fees
  5. Move to end of epoch
  6. Liquidity fees distributed
  7. LP receives no rewards 🔴

Expected behaviour

  1. LP commits liquidity and submits pegged orders to meet their commitment
  2. Market exits opening auction
  3. Recurring transfer setup to fund an ACCOUNT_TYPE_REWARD_LP_RECEIVED_FEES pool
  4. Trades generate fees
  5. Move to end of epoch
  6. Liquidity fees distributed
  7. LP receives full rewards 🟢

Steps to reproduce

1. cd vega
1. git checkout feat/rweard_lp_fees
1. cd core
1. go test -v ./integration/... --godog.format=pretty $(pwd)/integration/features/verified/rewards_lp_fees.feature

Software version

08fb257

Failing test

integration/features/verified/rewards_lp_fees.feature

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants