Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GQL API returning different transfer destination data than REST API #9747

Closed
sam-keen opened this issue Oct 11, 2023 · 0 comments · Fixed by #9748
Closed

[Bug]: GQL API returning different transfer destination data than REST API #9747

sam-keen opened this issue Oct 11, 2023 · 0 comments · Fixed by #9748
Assignees
Labels

Comments

@sam-keen
Copy link

sam-keen commented Oct 11, 2023

Problem encountered

Governance initiated transfers - specifically tested on new transfers, but may also apply to cancel transfers - there is a difference between the reported destination value from GQL and REST.

Observed behaviour

GQL:

Screenshot 2023-10-11 at 17 09 38

REST:

Screenshot 2023-10-11 at 17 09 59

Notice the "destination type" field has a different value. "ACCOUNT_TYPE_NETWORK_TREASURY" vs "ACCOUNT_TYPE_GENERAL"

Expected behaviour

The two APIs to give the same correct value

Steps to reproduce

Testable on a proposal on stagnet1.

On https://api.stagnet1.vega.rocks/graphql/ you can run this query:
{
  proposal(id: "dd9629cacfe528042bf5263c348546afdd941e433caa20eda5f820a454ff0e13") {
        terms {
          change {
            ...on NewTransfer {
              source
              sourceType
              destination
              destinationType
            }
          }
        }
      }
}

and the REST data can be found at https://api.n00.stagnet1.vega.xyz/api/v2/governance?proposalId=dd9629cacfe528042bf5263c348546afdd941e433caa20eda5f820a454ff0e13

Software version

v0.73.0-preview.13

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@sam-keen sam-keen added the bug label Oct 11, 2023
@gordsport gordsport assigned ze97286 and unassigned gordsport Oct 11, 2023
@gordsport gordsport moved this to Todo in Core Kanban Oct 11, 2023
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Oct 11, 2023
@vega-issues vega-issues moved this from Todo to Waiting Review in Core Kanban Oct 11, 2023
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Oct 11, 2023
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Oct 11, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Oct 11, 2023
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants