Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add unit test for upgrade block. #9781

Closed
jgsbennett opened this issue Oct 13, 2023 · 0 comments
Closed

[Bug]: Add unit test for upgrade block. #9781

jgsbennett opened this issue Oct 13, 2023 · 0 comments
Assignees

Comments

@jgsbennett
Copy link
Contributor

Problem encountered

This system test PR corrects a system test from checking that exactly the current block would be rejected by vega for protocol upgrade proposals. It did that so that it wouldn't be so susceptible to the nodes being fractionality out of sync with what the current block is. However, checking that the current block is rejected would make an excellent unit test, if we don't already have it.

To be clear: Vega behaves correctly at time of writing. This ticket is to check/add a unit test for exactly this case.

Observed behaviour

Upgrade proposal is rejected

Expected behaviour

Upgrade proposal is rejected

Steps to reproduce

1. See test_protocol_upgrade_rejection_invalid_heights

Software version

264e660

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@jgsbennett jgsbennett added the bug label Oct 13, 2023
@EVODelavega EVODelavega removed the bug label Oct 13, 2023
@gordsport gordsport moved this to Todo in Core Kanban Oct 13, 2023
@vega-issues vega-issues moved this from Todo to Waiting Review in Core Kanban Oct 23, 2023
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Oct 23, 2023
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Oct 23, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants