You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in was observed in the database that we have global insurance account with incorrect owner field (0x0). This incorrect account is created by datanode upon getting a transfer with a to/from account that don't yet exist, or more accurately don't exist in the format that datanode is looking for them. In this specific example, the transfer reports the to account of global insurance with "0000000000000000000000000000000000000000000000000000000000000000", which comes to represent the network owner, however it is not escaped as network owner (which would be recorded in the db as party 0x3) but rather as is ie a party 0x0. This leads to multiple global insurance (in this example) accounts in the database for the same asset.
Observed behaviour
See above.
Expected behaviour
In this case where vega core reports a transfer with a from/to "0000000000000000000000000000000000000000000000000000000000000000" they should be translated to network owner. There are 2 other types of edge cases that will not work with this:
in a recurring transfer with dispatch metric, the to of the transfer doesn't imply which accounts it's actually going to be dispatched to
in governance transfer to/from market account, the to/from are actually markets rather than party which is not interpreted correctly by datanode.
That said, I don't think it matters much. In both of the cases above, datanode may save some account id along with the transfer which is used for filtering transfers transactions so it may just be fine.
Steps to reproduce
1. Submit `xyz` transaction
2. With this payload
3. Query `abc` API
4. Observe the error
Software version
v0.73.0-preview.16
Failing test
No response
Jenkins run
No response
Configuration used
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered:
Problem encountered
in was observed in the database that we have global insurance account with incorrect owner field (0x0). This incorrect account is created by datanode upon getting a transfer with a to/from account that don't yet exist, or more accurately don't exist in the format that datanode is looking for them. In this specific example, the transfer reports the to account of global insurance with "0000000000000000000000000000000000000000000000000000000000000000", which comes to represent the network owner, however it is not escaped as network owner (which would be recorded in the db as party 0x3) but rather as is ie a party 0x0. This leads to multiple global insurance (in this example) accounts in the database for the same asset.
Observed behaviour
See above.
Expected behaviour
In this case where vega core reports a transfer with a from/to "0000000000000000000000000000000000000000000000000000000000000000" they should be translated to network owner. There are 2 other types of edge cases that will not work with this:
That said, I don't think it matters much. In both of the cases above, datanode may save some account id along with the transfer which is used for filtering transfers transactions so it may just be fine.
Steps to reproduce
Software version
v0.73.0-preview.16
Failing test
No response
Jenkins run
No response
Configuration used
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: