Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The referral set stats API gives wrong running notional volume #9915

Closed
JonRay15 opened this issue Oct 27, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@JonRay15
Copy link

Problem encountered

I have a set with only one particpant (my other key)

I run this query

query referrerStatsBySet{
  referralSetStats(
    setId:"876be7c89c40d4a898b886a17f0039f86063cb35223833e4d585cef18dc452b3",
    #pagination:{last:1}
  )
    {
    edges{
      node{
        partyId
        wasEligible
        discountFactor
        rewardFactor
        rewardsMultiplier
        rewardsFactorMultiplier
        epochNotionalTakerVolume
        referralSetRunningNotionalTakerVolume
        atEpoch
      }
    }
  }
}

Observed behaviour

The result shows I have the below

{
  "data": {
    "referralSetStats": {
      "edges": [
        {
          "node": {
            "partyId": "b62eafc46e6fadc6e45ae51de8bda199f0702131e5b23665f3411223c598acc2",
            "wasEligible": false,
            "discountFactor": "0",
            "rewardFactor": "0.01",
            "rewardsMultiplier": "3",
            "rewardsFactorMultiplier": "0.03",
            "epochNotionalTakerVolume": "2731931664",
            "referralSetRunningNotionalTakerVolume": "1000000",
            "atEpoch": 9789
          }
        }
      ]
    }
  }
}

So despite my own personal volume being 2731931664 the volume of the set is capped at 1000000 which is the value of the top tier.

In the previous epoch it was 500k which was the value for tier 2

Expected behaviour

I should be seeing the actual running volume, not the volume of the tier that I am in

Steps to reproduce

Outlined above

Software version

73 rc4

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@JonRay15
Copy link
Author

This may not be a bug

@JonRay15
Copy link
Author

Numbers have come down to something sensible now its been 2 epochs since I made a massive trade ... so THINK this is actually ok. And I dont have the means (or desire) to dig into the numbers further ... so I think we can close.

{
  "data": {
    "referralSetStats": {
      "edges": [
        {
          "node": {
            "partyId": "b62eafc46e6fadc6e45ae51de8bda199f0702131e5b23665f3411223c598acc2",
            "wasEligible": false,
            "discountFactor": "0.001",
            "rewardFactor": "0.01",
            "rewardsMultiplier": "3",
            "rewardsFactorMultiplier": "0.03",
            "epochNotionalTakerVolume": "10195",
            "referralSetRunningNotionalTakerVolume": "1064380",
            "atEpoch": 9793
          }
        },
        {
          "node": {
            "partyId": "099c59484e4a0db12d06dc52cb57f4c0e0b861a90d70d7afdfe6cd8e88d94612",
            "wasEligible": false,
            "discountFactor": "0",
            "rewardFactor": "0.01",
            "rewardsMultiplier": "3",
            "rewardsFactorMultiplier": "0.03",
            "epochNotionalTakerVolume": "50787",
            "referralSetRunningNotionalTakerVolume": "1064380",
            "atEpoch": 9793
          }
        }
      ]
    }
  }
}

@JonRay15 JonRay15 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Core Kanban Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants