Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA time on book calculation looking incorrect for LPs on existing markets #9951

Closed
davidsiska-vega opened this issue Nov 1, 2023 · 3 comments

Comments

@davidsiska-vega
Copy link
Contributor

davidsiska-vega commented Nov 1, 2023

All LPs reporting time on book as 0:
image

@wwestgarth says that in the snapshot the epoch start time is reported as

"epochStartTime": "-6795364578871345152"

which "isn't great".

Also each LP's "start of committment time" is also "-6795364578871345152":

type slaPerformance struct {
	s                 time.Duration
	start             time.Time // <---- THIS FELLA HERE
	previousPenalties *sliceRing[*num.Decimal]

	lastEpochBondPenalty      string
	lastEpochFeePenalty       string
	lastEpochTimeBookFraction string
	requiredLiquidity         string
	notionalVolumeBuys        string
	notionalVolumeSells       string
}
@davidsiska-vega
Copy link
Contributor Author

@wwestgarth whatever the ultimate fix - there is also an issue that even if the time was correct the LPs would have had no chance of meeting this if we only start counting from 10am UK time (because at that point they'd have missed 6pm - 10am).

So if we're doing a hotfix we want to either hardcode penalty to 0 for this special case, or count their time on book from the previous regime we had in 0.72.* as 1.

@davidsiska-vega
Copy link
Contributor Author

Or just let things be and then propose governance transfers out of the insurance pools.

@jeremyletang
Copy link
Member

fixed in tag v0.73.2

@github-project-automation github-project-automation bot moved this from Todo to Merged in Core Kanban Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Known Issues to In Testing in Known Issues Board Nov 1, 2023
@JonRay15 JonRay15 moved this from In Testing to Deployed to Mainnet in Known Issues Board Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Deployed to Mainnet
Development

No branches or pull requests

5 participants