Skip to content

Commit d3e50eb

Browse files
authored
Spark + Zeppelin fixes. (#68)
* fix #66 plot not resizing; * fix #67 Spark broken * fixed zep generator display implicit wrong * sortOrder shorthand syntax
1 parent 4bc1c48 commit d3e50eb

File tree

8 files changed

+298
-1918
lines changed

8 files changed

+298
-1918
lines changed

build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ lazy val spark = project.
176176
settings(commonSettings: _*).
177177
settings(
178178
libraryDependencies ++= Seq(
179-
"org.apache.spark" %% "spark-sql" % "[1.5,)" % "provided"
179+
"org.apache.spark" %% "spark-sql" % "[2.0,)" % "provided"
180180
)
181181
)
182182

core/src/main/scala/vegas/package.scala

+6-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,12 @@ package object vegas {
4747
val TimeUnit = Spec.TimeUnitEnums
4848
val Nice = Spec.NiceTimeEnums
4949

50-
val SortOrder = Spec.SortOrderEnums
50+
object SortOrder {
51+
val Ascending = Spec.SortOrderEnums.Ascending
52+
val Asc = Spec.SortOrderEnums.Ascending
53+
val Descending = Spec.SortOrderEnums.Descending
54+
val Desc = Spec.SortOrderEnums.Descending
55+
}
5156

5257
val Category10 = "category10"
5358
val Category20 = "category20"

core/src/main/scala/vegas/render/StaticHTMLRenderer.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,10 @@ case class StaticHTMLRenderer(specJson: String) extends BaseHTMLRenderer {
5656
| <script>
5757
| if (typeof resizeIFrame != 'function') {
5858
| function resizeIFrame(el, k) {
59-
| el.style.height = el.contentWindow.document.body.scrollHeight + 'px';
60-
| if (k <= 7) { setTimeout(function() { resizeIFrame(el, k+1) }, 1000) };
59+
| $$(el.contentWindow.document).ready(function() {
60+
| el.style.height = el.contentWindow.document.body.scrollHeight + 'px';
61+
| });
62+
| if (k <= 10) { setTimeout(function() { resizeIFrame(el, k+1) }, 1000 + (k * 250)) };
6163
| }
6264
| }
6365
| $$().ready( function() { resizeIFrame($$('#${frameName}').get(0), 1); });

core/src/test/scala/vegas/fixtures/VegasPlots.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ object VegasPlots {
5050
Vegas("Plot to show Binning options").
5151
withURL(Movies).
5252
mark(Bar).
53-
encodeX("Worldwide_Gross", Quantitative, bin=Bin(maxbins=20.0), sortOrder=SortOrder.Descending).
54-
encodeY(field="*", Quantitative, aggregate=AggOps.Count)
53+
encodeX("Worldwide_Gross", Quant, bin=Bin(maxbins=20.0), sortOrder=SortOrder.Desc).
54+
encodeY(field="*", Quant, aggregate=AggOps.Count)
5555

5656
val ColoredTextScatterPlot =
5757
Vegas("Plot to show usage of encodeText").

core/src/test/scala/vegas/util/NotebookGenerator.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,14 @@ class JupyterGenerator extends NotebookGenerator {
119119
class ZeppelinGenerator extends NotebookGenerator {
120120

121121
def preamble(version: String) =
122-
("", s"""com.github.aishfenton:vegas-spark_2.10:${version}""") ::
122+
("", s"""
123+
|%dep
124+
|z.load("com.github.aishfenton:vegas-spark_2.11:${version}")""".stripMargin) ::
123125
("", """
124126
|import vegas._
125127
|import vegas.data.External._
126128
|import vegas.render.HTMLRenderer._
127-
|implicit val displayer: String => Unit = (s) => s"%html + $s" """.stripMargin) ::
129+
|implicit val displayer: String => Unit = (s) => println(s"%html $s")""".stripMargin) ::
128130
Nil
129131

130132
def mkNotebook(plots: List[(String, String)]) = {

0 commit comments

Comments
 (0)