Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download file with default provider does not work #8

Closed
wants to merge 2 commits into from
Closed

Download file with default provider does not work #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2930e2a
Updated to latest AWS SDK
sfontes Oct 30, 2018
89e0615
Removed requirement of access key and secret key
sfontes Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<groupId>com.upplication.maven.plugins</groupId>
<artifactId>s3-download-maven-plugin</artifactId>
<version>1.0.2-SNAPSHOT</version>
<version>1.0.4-SNAPSHOT</version>
<packaging>maven-plugin</packaging>

<name>S3 download maven plugin</name>
Expand Down Expand Up @@ -78,7 +78,7 @@
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk</artifactId>
<version>1.3.26</version>
<version>1.9.6</version>
</dependency>

<dependency>
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Configuration parameters
|bucketName|The name of the bucket|*yes*| |
|source|The source amazon s3 file key. Empty to download the whole bucket.|*no*| |
|destination|The destination file or destination folder. Directories *MUST* end with */*| *yes*| |
|accessKey|S3 access key | *yes* | if unspecified, uses the Default Provider, falling back to env variables |
|secretKey|S3 secret key | *yes* | if unspecified, uses the Default Provider, falling back to env variables |
|accessKey|S3 access key | *no* | if unspecified, uses the Default Provider, falling back to env variables |
|secretKey|S3 secret key | *no* | if unspecified, uses the Default Provider, falling back to env variables |
|endpoint|Use a different s3 endpoint| *no* | s3.amazonaws.com |

Example: Download a bucket
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/upplication/maven/plugins/s3/download/S3DownloadMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ public class S3DownloadMojo extends AbstractMojo {
/**
* Access key for S3.
*/
@Parameter(property = "s3-download.accessKey", required = true)
@Parameter(property = "s3-download.accessKey")
private String accessKey;

/**
* Secret key for S3.
*/
@Parameter(property = "s3-download.secretKey", required = true)
@Parameter(property = "s3-download.secretKey")
private String secretKey;

/**
Expand Down