Merge pull request #6 from venmo/privateSet

Implemented private(set) on properties which need private setters.
venmo · Jun 14, 2018 · e7d1b13 · e7d1b13
2 parents 5a9f5d5 + 65b463f
commit e7d1b13
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 18 deletions.
diff --git a/QuizTrain/Network/Operations/GetConfigurationGroupsOperation.swift b/QuizTrain/Network/Operations/GetConfigurationGroupsOperation.swift
@@ -4,14 +4,13 @@ class GetConfigurationGroupsOperation: AsyncOperation {
 
     // MARK: Properties
 
-    private weak var _api: ObjectAPI?
-    var api: ObjectAPI? { return _api }
+    private(set) weak var api: ObjectAPI?
     let projectId: Project.Id
 
     // MARK: Init
 
     init(api: ObjectAPI, projectId: Project.Id) {
-        self._api = api
+        self.api = api
         self.projectId = projectId
     }
 
@@ -33,14 +32,13 @@ class GetConfigurationGroupsOperation: AsyncOperation {
         state = .executing
 
         api.getConfigurationGroups(inProjectWithId: projectId) { [weak self] (outcome) in
-            self?._outcome = outcome
+            self?.outcome = outcome
             self?.state = .finished
         }
     }
 
     // MARK: Completion
 
-    private var _outcome: Outcome<[ConfigurationGroup], ObjectAPI.GetError>?
-    var outcome: Outcome<[ConfigurationGroup], ObjectAPI.GetError>? { return _outcome }
+    private(set) var outcome: Outcome<[ConfigurationGroup], ObjectAPI.GetError>?
 
 }
diff --git a/QuizTrain/Network/Operations/GetProjectOperation.swift b/QuizTrain/Network/Operations/GetProjectOperation.swift
@@ -4,14 +4,13 @@ class GetProjectOperation: AsyncOperation {
 
     // MARK: Properties
 
-    private weak var _api: ObjectAPI?
-    var api: ObjectAPI? { return _api }
+    private(set) weak var api: ObjectAPI?
     let projectId: Project.Id
 
     // MARK: Init
 
     init(api: ObjectAPI, projectId: Project.Id) {
-        self._api = api
+        self.api = api
         self.projectId = projectId
     }
 
@@ -33,14 +32,13 @@ class GetProjectOperation: AsyncOperation {
         state = .executing
 
         api.getProject(projectId) { [weak self] (outcome) in
-            self?._outcome = outcome
+            self?.outcome = outcome
             self?.state = .finished
         }
     }
 
     // MARK: Completion
 
-    private var _outcome: Outcome<Project, ObjectAPI.GetError>?
-    var outcome: Outcome<Project, ObjectAPI.GetError>? { return _outcome }
+    private(set) var outcome: Outcome<Project, ObjectAPI.GetError>?
 
 }
diff --git a/QuizTrain/Network/Operations/GetTemplatesOperation.swift b/QuizTrain/Network/Operations/GetTemplatesOperation.swift
@@ -4,14 +4,13 @@ class GetTemplatesOperation: AsyncOperation {
 
     // MARK: Properties
 
-    private weak var _api: ObjectAPI?
-    var api: ObjectAPI? { return _api }
+    private(set) weak var api: ObjectAPI?
     let projectId: Project.Id
 
     // MARK: Init
 
     init(api: ObjectAPI, projectId: Project.Id) {
-        self._api = api
+        self.api = api
         self.projectId = projectId
     }
 
@@ -33,14 +32,13 @@ class GetTemplatesOperation: AsyncOperation {
         state = .executing
 
         api.getTemplates(inProjectWithId: projectId) { [weak self] (outcome) in
-            self?._outcome = outcome
+            self?.outcome = outcome
             self?.state = .finished
         }
     }
 
     // MARK: Completion
 
-    private var _outcome: Outcome<[Template], ObjectAPI.GetError>?
-    var outcome: Outcome<[Template], ObjectAPI.GetError>? { return _outcome }
+    private(set) var outcome: Outcome<[Template], ObjectAPI.GetError>?
 
 }