Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Lint Checks Failing on Main Branch #146

Open
Akhilesh-max opened this issue Jan 4, 2025 · 5 comments
Open

Required Lint Checks Failing on Main Branch #146

Akhilesh-max opened this issue Jan 4, 2025 · 5 comments

Comments

@Akhilesh-max
Copy link
Contributor

Akhilesh-max commented Jan 4, 2025

Some of the required lint checks (make lint) are failing on the main branch on my local environment without me having made any changes.

Screenshot 2025-01-04 at 8 16 19 AM
@Akhilesh-max
Copy link
Contributor Author

@deeglaze @thomas-fossati, am I missing anything?

@thomas-fossati
Copy link
Contributor

@Akhilesh-max, could you please copy the output of:

golangci-lint --version

and

go version

@Akhilesh-max
Copy link
Contributor Author

Akhilesh-max commented Jan 6, 2025

@thomas-fossati,

  1. golangci-lint --version
    golangci-lint has version 1.63.4 built with go1.23.4 from c114969 on 2025-01-03T19:29:37Z

  2. go version
    go version go1.23.4 darwin/arm64

However, after updating to the versions specified in the our GitHub actions workflow file (linters.yml), the linter no longer throws errors on the main branch.

I’ve also created a PR to update the README so that other devs can reference the apt versions and avoid similar issues.
PTAL : #147

Thanks!

@thomas-fossati
Copy link
Contributor

thomas-fossati commented Jan 6, 2025

[...]
However, after updating to the versions specified in the our GitHub actions workflow file (linters.yml), the linter no longer throws errors on the main branch.

👍

I’ve also created a PR to update the README so that other devs can reference the apt versions and avoid similar issues. PTAL : #147

Just for the records: that PR is closed and superseded by #148.

@Akhilesh-max
Copy link
Contributor Author

@thomas-fossati, can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants