Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-safe body for useCompletion etc. #3838

Open
umstek opened this issue Nov 22, 2024 · 0 comments
Open

Type-safe body for useCompletion etc. #3838

umstek opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@umstek
Copy link

umstek commented Nov 22, 2024

Feature Description

When calling the complete method returned by useCompletion (etc.), we can pass our own data like so:

  const {
    complete,
    completion,
    error,
    isLoading,
  } = useCompletion({
    api: `${config.baseURL}/ai/completion`,
  });
await complete(promptText, { body: { model: 'fast' } });

Currently, useCompletion doesn't accept type arguments. If it did, we could've made the body passed to complete type safe.

Use Cases

This would help us avoid mistakes.

Additional context

This is definitely not a high priority, but I believe it is a nice to have.

@umstek umstek added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant