Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] "with-aws-amplify" but with App Router instead of Pages Router #57127

Closed
jeffpball opened this issue Oct 20, 2023 · 10 comments
Closed
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers locked

Comments

@jeffpball
Copy link

jeffpball commented Oct 20, 2023

What is the improvement or update you wish to see?

I would like to see a repo created in addition to the existing "with-aws-amplify" repo, maybe titled "with-aws-amplify-approuter" that would provide the same Todo app but using App Router instead of Pages Router

Is there any context that might help us understand?

Provide newcomers to Next.js and AWS Amplify a sample Todo app that uses App Router in addition to other features that are already implemented in the "with-aws-amplify" example repo, which uses the Pages Router

Note: I'm not sure if "Documentation" was the correct category to create an Issue for this topic. I didn't see a clear set of steps for requesting a new example repo.

@jeffpball jeffpball added the Documentation Related to Next.js' official documentation. label Oct 20, 2023
@balazsorban44
Copy link
Member

hi, generally we would just like to convert examples to App Router instead of maintaining multiple variants. Feel free to work on it if you like, open a PR, and we can review!

@balazsorban44 balazsorban44 added good first issue Easy to fix issues, good for newcomers examples Issue was opened via the examples template. and removed Documentation Related to Next.js' official documentation. labels Oct 20, 2023
@Rakshit358
Copy link

Hey can I work on this please....

@adarshbyte
Copy link

#56844 aws-amplify package has issue running with turbopack, the amplify core developer say they are using some packages like "fs" which are optional to be compiled and compiled by turbopack but not by webpack. And hence breaking when i run npm run dev --turbo

@jeffpball
Copy link
Author

Hey can I work on this please....

Not sure if there is someone designated to say yes or no, but as far as I'm concerned you should go for it. I am going to try working on it too just for my own edification and will make a PR if I come up with anything good. I'll look out for any other PRs on that repo in case anyone gets to it before I do.

@its-kunal
Copy link
Contributor

I would like to contribute to this issue.

@Marquis4484
Copy link

Can I contribute also?

@adarsh-drishya
Copy link

Instead of asking, create a PR ppl

@shanu-user
Copy link

I am not able to execute the with-aws-amplify project to see how todo app is designed and it's working.

@leerob
Copy link
Member

leerob commented Oct 31, 2023

We're planning to direct users to the official Amplify documentation versus this example, since they're maintaining the documentation and guidance on their side. Let me get a PR for this 🙏

https://docs.amplify.aws/guides/hosting/nextjs/q/platform/js/

Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers locked
Projects
None yet
Development

No branches or pull requests

9 participants