Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLoadContext for Vercel does not accept promises. #114

Open
mp-mb opened this issue May 22, 2024 · 0 comments
Open

getLoadContext for Vercel does not accept promises. #114

mp-mb opened this issue May 22, 2024 · 0 comments

Comments

@mp-mb
Copy link

mp-mb commented May 22, 2024

Every other adapter seems to accept a promise to load the AppContext before passing it to the loaders. In Vercel's adapter this isn't the case. Since its a common practice to prepare the context and load data, it would make sense to add this here.

image

packages/vercel-remix/server.ts
(Obviously also adjusting the TS Interface)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant