feat(bun): support bun.lock
#9783
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
chrisolszewski/turbo-4268-warning-when-using-text-based-bun-lockfile
branch
from
7400701 to
f50149a
Compare
|
This is a great step toward support |
| // npm -> [ | ||
| // "name@version", | ||
| // registry (TODO: remove if default), | ||
| // INFO, |
There was a problem hiding this comment.
To clarify, this is the structure of a package entry? Bun stores it in an array? And what is the .bun-tag?
There was a problem hiding this comment.
To clarify, this is the structure of a package entry? Bun stores it in an array?
Yes these are the various variants of a package entry according to this comment
And what is the .bun-tag?
It seems to be a special string, I haven't found where it is generated.
| } | ||
|
|
||
| fn less_specific_key(key: &str) -> Option<&str> { | ||
| let slash_idx = key.find('/')?; |
There was a problem hiding this comment.
tiny nit: split_once might work better here
There was a problem hiding this comment.
This is one of those cases where might need a str that includes the / I split on so I feel like find is a little easier to work with here.
| // TODO | ||
| } | ||
| let syntax_tree = parsed_json.syntax(); | ||
| let format = biome_json_formatter::format_node( |
There was a problem hiding this comment.
if you want a slightly shorter trip, I think you can use biome_deserialize to get a serde_json::Value, then use serde to deserialize that into BunLockfile.
There was a problem hiding this comment.
I'm not seeing serde_json::Value as being supported by biome_deserialize.
|
Big thanks to @chris-olszewski for working on this!!! Can't wait to have this in a release |
|
Hey, is there anything that could be done to help move this along? We use Bun with Turbo and the conversion to a Yarn lockfile has some issues (whether it's on Bun's side or Turbo's, I'm not sure - #9628), which means we can't use Turbo reliably in our Dockerfiles. |
chris-olszewski
force-pushed
the
chrisolszewski/turbo-4268-warning-when-using-text-based-bun-lockfile
branch
from
d3a0b51 to
aa4deff
Compare
Description
Closes #9628
Switch over from our usage of
yarn.lockand directly supportbun.lockparsing.We use
biometo strip out the trailing commas that appear in theworkspacesandpackagesobjects to leverageserdewhich I am more competent in. We can switch tobiomein the future and avoid a second pass, but I do not know how to do correct deserialization logic forPackageEntry(seede.rsfor examples of what this looks like) inbiome.I will call out is the fact that the lockfile keys in
bun.lockaren't used directly unlike other lockfile implementation. Instead we use resolved package identifiers e.g.package@(protocol:)?version. The keys themselves can shift when the underlying package does not change resulting in incorrect behavior.A quick example to illustrate:
adepends on[email protected]bdepends on[email protected][email protected]will get they key ofsharedsinceais beforeb[email protected]will get a key ofb/sharedaupdates to[email protected], then thesharedkey will now point to[email protected]bsince it's key changed fromb/sharedtosharedand not rebuildasince it's key remainedsharedThis PR does not add support for
turbo prune.Reviewing each commit on it's own would probably be helpful.
Testing Instructions
Unit tests. Manual testing on a
create-turborepository.