Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to customize the generated key space for graphite metrics #32

Open
Crim opened this issue May 20, 2016 · 1 comment
Open

Be able to customize the generated key space for graphite metrics #32

Crim opened this issue May 20, 2016 · 1 comment

Comments

@Crim
Copy link
Contributor

Crim commented May 20, 2016

In our setup we end up with a ton of new keys every time we redeploy our topologies because executor ids, hostnames, worker ports, etc.. all change. As a result our graphs end up having to wildcard a lot of keys in order to work from deploy to deploy. It seems like if it was possible to customize what key space was generated, we could eliminate the bits we don't care about.

I've created #31 to provide a way to customize the generated graphite key space. To keep backwards compatibility, this solution is a bit messier than say if I just overloaded the "metrics.graphite.prefix" to handle this. If backwards compatibility isn't such a big deal, I can refactor this and clean it up a bit.

@Crim
Copy link
Contributor Author

Crim commented May 20, 2016

Although I realize now in order for this to work correctly, I may need to also combine now non-unique keys before sending them over to graphite. This may require a bit of tinkering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant