PR to kornia?

[ducha-aiki]

Hi,

Would you be interested in integrating DEAL into kornia.features alongside with HardNet?

--
Best, Dmytro

[guipotje]

Hello Dmytro,

Yes, we are very interested in contributing to Kornia! I will check Kornia's PR guidelines and will start the process of adapting the code of this repo. I will update you on this issue before I create a PR to Kornia. Thank you for the invitation.

Kind regards,

Guilherme Potje

[ducha-aiki]

@guipotje I am glad to hear that :)
I think that the most reasonable would be to inherit from kornia.feature.LAFDescriptor and put there the deformation-aware patch extraction and description.

We also don't use OpenCV keypoints, and use kornia.feature.LAF instead. The conversion is simple, one can generate LAF using kornia.feature. laf_from_center_scale_ori, e.g. as in this https://github.com/ducha-aiki/kornia_moons/blob/master/kornia_moons/feature.py#L19

[guipotje]

I think that the most reasonable would be to inherit from kornia.feature.LAFDescriptor and put there the deformation-aware patch extraction and description.

Sounds nice @ducha-aiki, thank you for the tips. I'll adapt the code for that, and also use the kornia.feature.LAF instead of OpenCV keypoints.