Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnets should be part of VirtualNetwork #51

Open
vermacodes opened this issue Nov 6, 2023 · 0 comments
Open

Subnets should be part of VirtualNetwork #51

vermacodes opened this issue Nov 6, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vermacodes
Copy link
Owner

To be able to provide feature to add multiple virutal network, we need to fix the vnet and subnets relationship. I propose that subnets should be part of a specific vnet. so instead of

    "virtualNetworks": [
        {
            "addressSpace": [
                "10.1.0.0/16"
            ]
        }
    ],
    "subnets": [
        {
            "addressPrefixes": [
                "10.1.1.0/24"
            ],
            "name": "AzureFirewallSubnet"
        },
        {
            "addressPrefixes": [
                "10.1.2.0/24"
            ],
            "name": "JumpServerSubnet"
        },
        {
            "addressPrefixes": [
                "10.1.3.0/24"
            ],
            "name": "KubernetesSubnet"
        },
        {
            "addressPrefixes": [
                "10.1.4.0/24"
            ],
            "name": "AppGatewaySubnet"
        },
        {
            "addressPrefixes": [
                "10.1.5.0/24"
            ],
            "name": "AROMasterSubnet"
        },
        {
            "addressPrefixes": [
                "10.1.6.0/24"
            ],
            "name": "AROWorkerSubnet"
        },
        {
            "addressPrefixes": [
                "10.1.7.0/24"
            ],
            "name": "KubernetesVirtualNodeSubnet"
        }
    ],

it should be

    "virtualNetworks": [
        {
            "addressSpace": [
                "10.1.0.0/16"
            ],
            "subnets": [
                {
                    "addressPrefixes": [
                        "10.1.1.0/24"
                    ],
                    "name": "AzureFirewallSubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.2.0/24"
                    ],
                    "name": "JumpServerSubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.3.0/24"
                    ],
                    "name": "KubernetesSubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.4.0/24"
                    ],
                    "name": "AppGatewaySubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.5.0/24"
                    ],
                    "name": "AROMasterSubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.6.0/24"
                    ],
                    "name": "AROWorkerSubnet"
                },
                {
                    "addressPrefixes": [
                        "10.1.7.0/24"
                    ],
                    "name": "KubernetesVirtualNodeSubnet"
                }
            ],
        }
    ]
@vermacodes vermacodes self-assigned this Nov 6, 2023
@vermacodes vermacodes added the enhancement New feature or request label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant