Update README.md #26
Merged
Update README.md #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete revision: - Copy edits - badge links - link to docs/grafana
|
I like the new format of the readme. @roypaulin do you mind taking a look? |
|
I also like the new format. I think we should have a min vertica version and then add a max later when we know it. Also Shouldn't we change the min version to the current vertica release? |
Yeah, the plan is to add a max once we make a change to the metrics that break dashboards (rename and/or remove of a metric). It is left out for now since none have a max. The version you see now is the min.
Technically the dashboards should work with 23.4.0 since we have added any new metrics in this PI. |
spilchen
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised README to prepare for public consumption:
*Before going public, links to revision and dashboard ID need to be updated with correct links when the URLs exist