Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group feature, is_public should be boolean #256

Open
runout-at opened this issue May 4, 2018 · 3 comments · May be fixed by #257
Open

group feature, is_public should be boolean #256

runout-at opened this issue May 4, 2018 · 3 comments · May be fixed by #257

Comments

@runout-at
Copy link
Contributor

The groups table has a field is_public which is of type string

Since all other Checkbox fields in vexim are boolean (integer in DB) i'd like to change this.
Involved is one router.
@runout-at runout-at linked a pull request May 5, 2018 that will close this issue
Open
@Udera
Copy link
Collaborator

Udera commented May 8, 2018

postgresql does not seem to have the tinyint field type ....

https://stackoverflow.com/questions/1942586/comparison-of-database-column-types-in-mysql-postgresql-and-sqlite-cross-map

@runout-at
Copy link
Contributor Author

my PR is using smallint for pgsql:

"is_public" smallint NOT NULL DEFAULT '1' CHECK("enabled" BETWEEN 0 AND 1),

@rimas-kudelis
Copy link
Collaborator

Since this is a cosmetic change only, but it involves the database, I would prefer to have this changed in 3.0, when we have proper migration support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change is_public in groups table to tinyint
3 participants
@runout-at @rimas-kudelis @Udera