From 6b02c11d667adff24daf611f9b14815d27963674 Mon Sep 17 00:00:00 2001 From: stratospher <44024636+stratospher@users.noreply.github.com> Date: Wed, 17 Apr 2024 13:05:47 +0530 Subject: [PATCH] test: Fix intermittent issue in p2p_handshake.py If we reuse the same port when disconnecting and establishing connections again, we might hit this scenario: - disconnection is done on python side for P2PConnection - disconnection is not complete on c++ side for TestNode - we're trying to establish a new connection on same port again Prevent this scenario from happening by ensuring disconnection on c++ side for TestNode as well. --- test/functional/p2p_handshake.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/p2p_handshake.py b/test/functional/p2p_handshake.py index f0b62e291d322..dd19fe93334bb 100755 --- a/test/functional/p2p_handshake.py +++ b/test/functional/p2p_handshake.py @@ -41,6 +41,7 @@ def add_outbound_connection(self, node, connection_type, services, wait_for_disc peer.sync_with_ping() peer.peer_disconnect() peer.wait_for_disconnect() + self.wait_until(lambda: len(node.getpeerinfo()) == 0) def test_desirable_service_flags(self, node, service_flag_tests, desirable_service_flags, expect_disconnect): """Check that connecting to a peer either fails or succeeds depending on its offered