-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI and use old headless by default in chromium based browsers #157
Conversation
@vgalin review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, you could consider keeping the comma at the end of the line, it makes diffs cleaner for current and future commits on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a shorter name for the should_use_new_headless_mode
attribute ? Maybe use_new_headless_mode
, or even use_new_headless
.
Thank you for taking the time to create this PR. Along with the (minor) reviews, I have a question myself: What happens if a user is using an older version of Chrome(ium)? Does it break the headless mode because Regardless of the outcome, I see two possible courses of action:
Do as you see fit, I don't have a preference at the moment. If I change my mind, I can always add the second option later. |
So does this mean the |
@jrb-github Not exactly. This only concerns the CLI script of If you're only using |
Hm. Maybe I should branch this off into a separate issue, but I found this pull request because of a recent change in behavior where I was successfully using the EDIT - I assume based on your comments that the behavior I'm seeing is unrelated. I submitted a new issue here. |
fix #156
fix #155
Reference links
The moment mentioned in the quote above has arrived.