Add docker support #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use size_t for void pointer cast
Repos hosted in GitHub have the advantage of a rich API. The variables where this change will be reflected are: LLVM_GIT_URL, WITH_LLVM_URL CLANG_GIT_URL, CLANG_GIT_URL CLING_GIT_URL, CLING_GIT_URL
- prefer new method if the repos are hosted in Github - fix an IndexError bug in home-grown wget()
CPT disk space usage optimizations.
CPT improvements.
| # get the build from docker hub | ||
| docker pull maddouri/cling-ubuntu-docker | ||
| # run it ! (the entry point is cling) | ||
| docker run -it maddouri/cling-ubuntu-docker |
There was a problem hiding this comment.
What does a prebuilt image mean? Do we need this to go in cling's mainline?
There was a problem hiding this comment.
Just a Docker Image that someone (in this instance, I) pushed to Docker Hub.
Apart from the files in tools/docker, there is nothing else to merge.
If you decide to merge this PR, you will have the following options:
- Let the users build their own images, (on their own machines)
- Build your own "official" image, push it to your own Docker Hub repo, and let the users know that they can pull it directly from Docker Hub,
- Let the users pull other users' images. (e.g. the ones I've pushed to Docker Hub)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a followup to #85
I think that it may prove interesting to have a docker build. Most notably, it allows the following:
tools/docker/README.md)I wasn't sure where exactly to put the files, so I used
tools/docker. Feel free to propose another location.I have already published a standalone version at https://github.com/maddouri/cling-ubuntu-docker
You can test it by running the following: