From 112a58211e6aaae7a84d4e2bb180469f6d236a32 Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 6 Oct 2023 08:25:56 +0200 Subject: [PATCH 1/9] Update for next development version --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dcb5ea6..52af69f 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ This tool helps to control the retry-behaviour in external-task-handlers based on the official java-client provided by Camunda BPM - 1.7.0 + 1.7.1-SNAPSHOT 2021 From 4fc89cbd2276af5a7001534a3589d4880ec42b52 Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 6 Oct 2023 08:36:51 +0200 Subject: [PATCH 2/9] readme --- README.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/README.md b/README.md index 83d7802..5e966b4 100644 --- a/README.md +++ b/README.md @@ -158,12 +158,17 @@ any issue, please feel free to contact me. | 1.4.2 | 7.17.0 | 2.7.x | | 1.5.x | 7.18.0 | 2.7.x | | 1.6.x | 7.19.0 | 2.7.x | +| 1.7.x | 7.19.0 | 2.7.x | ## ๐Ÿคน Collaboration This tool was build by viadee Unternehmensberatung AG. If you are interested to find out what else we are doing, check out our website [viadee.de](https://www.viadee.de/en). If you have any feedback, ideas or extensions feel free to contact or create a GitHub issue. +## ๐Ÿ† Thanks + +* Many thanks to [@ChrisSchoe][u_chrisschoe] for making the external-task-retry-aspect spring-boot-3-ready ([#107][i107]) + ## ๐Ÿ“ซ Contact [![rnschk](https://img.shields.io/twitter/follow/rnschk.svg)](https://twitter.com/rnschk) @@ -171,3 +176,7 @@ If you have any feedback, ideas or extensions feel free to contact or create a G ## ๐Ÿ”‘ License [![](https://img.shields.io/github/license/viadee/external-task-retry-aspect)](https://github.com/viadee/external-task-retry-aspect/blob/master/LICENSE) + +--- +[i107]: https://github.com/viadee/external-task-retry-aspect/issues/107 +[u_ChrisSchoe]: https://github.com/ChrisSchoe From 843d50309743c9cea46d1d6bbbafa71a8b705490 Mon Sep 17 00:00:00 2001 From: Florian Runschke <5700718+rnschk@users.noreply.github.com> Date: Fri, 6 Oct 2023 09:16:11 +0200 Subject: [PATCH 3/9] Update pom.xml --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 52af69f..04ff66b 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ This tool helps to control the retry-behaviour in external-task-handlers based on the official java-client provided by Camunda BPM - 1.7.1-SNAPSHOT + 1.7.2-SNAPSHOT 2021 From 15342d0a8e796e1adb5ffb12d68e121525e837ef Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:08:17 +0200 Subject: [PATCH 4/9] Update versions for feature branch --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 04ff66b..3b6bdba 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ This tool helps to control the retry-behaviour in external-task-handlers based on the official java-client provided by Camunda BPM - 1.7.2-SNAPSHOT + 1.7.2-version-updates-SNAPSHOT 2021 From d2e07ca6751e65b679d3c7883069ec8ed3442a3e Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:44:48 +0200 Subject: [PATCH 5/9] version updates * jdk 17 * camunda 7.20 * spring-boot 3.1 * junit 5 * maven-plugins --- pom.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/pom.xml b/pom.xml index 3b6bdba..05ad94c 100644 --- a/pom.xml +++ b/pom.xml @@ -32,26 +32,26 @@ - 1.8 + 17 8 8 - 2.7.11 - 7.19.0 + 3.1.4 + 7.20.0 3.11 - 4.13.2 + 5.10.0 4.10.0 - 3.0.0 - 3.2.1 + 3.0.1 + 3.3.0 3.11.0 4.2 3.5.0 - 3.0.1 + 3.1.0 2.15.0 - 1.19.0 + 1.20.0 @@ -100,9 +100,9 @@ - junit - junit - ${junit.version} + org.junit.jupiter + junit-jupiter-engine + ${junit-jupiter.version} test From f90f48d446af99bdc83978c7d915b3143928c3d7 Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:45:41 +0200 Subject: [PATCH 6/9] update junit5 --- .../camunda/externaltask/retry/aspect/BaseTest.java | 10 +++++----- .../aspect/ExternalTaskRetryAspectPropertiesTest.java | 5 +++-- .../behaviour/CustomRetryTimeCycleIdentifierTest.java | 4 ++-- .../DefaultBehaviourForExceptionTypesTest.java | 2 +- .../retry/aspect/behaviour/EdgeCaseTest.java | 4 ++-- .../aspect/behaviour/InvalidDefaultBehaviourTest.java | 2 +- .../behaviour/InvalidRetryTimeCycleValuesTest.java | 2 +- .../retry/aspect/behaviour/RetryTimeCycleListTest.java | 2 +- 8 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/BaseTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/BaseTest.java index cd350dd..89ae79c 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/BaseTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/BaseTest.java @@ -36,14 +36,14 @@ import org.aspectj.lang.JoinPoint; import org.camunda.bpm.client.task.ExternalTask; import org.camunda.bpm.client.task.ExternalTaskService; -import org.junit.Before; -import org.junit.runner.RunWith; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.ArgumentCaptor; import org.mockito.Mockito; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.test.context.ActiveProfiles; import org.springframework.test.context.ContextConfiguration; -import org.springframework.test.context.junit4.SpringRunner; +import org.springframework.test.context.junit.jupiter.SpringExtension; import java.io.PrintWriter; import java.io.StringWriter; @@ -60,7 +60,7 @@ @SuppressWarnings({"unchecked", "rawtypes"}) @ContextConfiguration(classes = {ExternalTaskRetryAspectAutoConfiguration.class}) @ActiveProfiles("test") -@RunWith(SpringRunner.class) +@ExtendWith(SpringExtension.class) public abstract class BaseTest { //@formatter:off @@ -87,7 +87,7 @@ public abstract class BaseTest { protected ExternalTaskRetryAspectProperties properties; - @Before + @BeforeEach public void initTestData() { Mockito.reset(this.externalTask, this.externalTaskService, this.joinPoint); Mockito.when(this.joinPoint.getTarget()).thenReturn(Object.class); diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/ExternalTaskRetryAspectPropertiesTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/ExternalTaskRetryAspectPropertiesTest.java index dba1de4..cdf1bf1 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/ExternalTaskRetryAspectPropertiesTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/ExternalTaskRetryAspectPropertiesTest.java @@ -32,9 +32,10 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect; import de.viadee.bpm.camunda.externaltask.retry.aspect.config.ExternalTaskRetryAspectProperties; -import org.junit.Test; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.Assert.assertEquals; public class ExternalTaskRetryAspectPropertiesTest { diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/CustomRetryTimeCycleIdentifierTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/CustomRetryTimeCycleIdentifierTest.java index 49ed646..9265234 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/CustomRetryTimeCycleIdentifierTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/CustomRetryTimeCycleIdentifierTest.java @@ -32,10 +32,10 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect.behaviour; import de.viadee.bpm.camunda.externaltask.retry.aspect.BaseTest; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.springframework.test.context.TestPropertySource; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; @TestPropertySource(properties = "de.viadee.bpm.camunda.external-task.retry-config.identifier=CUSTOM_SOMETHING") diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/DefaultBehaviourForExceptionTypesTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/DefaultBehaviourForExceptionTypesTest.java index 7db92a1..d1ef420 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/DefaultBehaviourForExceptionTypesTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/DefaultBehaviourForExceptionTypesTest.java @@ -36,7 +36,7 @@ import de.viadee.bpm.camunda.externaltask.retry.aspect.error.InstantIncidentException; import org.camunda.bpm.engine.variable.VariableMap; import org.camunda.bpm.engine.variable.Variables; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.mockito.Mockito.when; diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/EdgeCaseTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/EdgeCaseTest.java index 7d05296..0bccbcf 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/EdgeCaseTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/EdgeCaseTest.java @@ -32,9 +32,9 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect.behaviour; import de.viadee.bpm.camunda.externaltask.retry.aspect.BaseTest; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.fail; +import static org.junit.jupiter.api.Assertions.fail; import static org.mockito.Mockito.when; diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidDefaultBehaviourTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidDefaultBehaviourTest.java index fe1f554..97b823e 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidDefaultBehaviourTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidDefaultBehaviourTest.java @@ -32,7 +32,7 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect.behaviour; import de.viadee.bpm.camunda.externaltask.retry.aspect.BaseTest; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.springframework.test.context.TestPropertySource; import static org.mockito.Mockito.when; diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidRetryTimeCycleValuesTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidRetryTimeCycleValuesTest.java index 2d6672e..7fffc91 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidRetryTimeCycleValuesTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/InvalidRetryTimeCycleValuesTest.java @@ -32,7 +32,7 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect.behaviour; import de.viadee.bpm.camunda.externaltask.retry.aspect.BaseTest; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.springframework.test.context.TestPropertySource; import static org.mockito.Mockito.when; diff --git a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/RetryTimeCycleListTest.java b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/RetryTimeCycleListTest.java index 71fb997..a6d0d57 100644 --- a/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/RetryTimeCycleListTest.java +++ b/src/test/java/de/viadee/bpm/camunda/externaltask/retry/aspect/behaviour/RetryTimeCycleListTest.java @@ -32,7 +32,7 @@ package de.viadee.bpm.camunda.externaltask.retry.aspect.behaviour; import de.viadee.bpm.camunda.externaltask.retry.aspect.BaseTest; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.Objects; From d804ba55de227734f01aa1f0d748d30140f2b00e Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:47:36 +0200 Subject: [PATCH 7/9] update readme --- README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 5e966b4..5fa5d4e 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # external-task-retry-aspect [![](https://img.shields.io/maven-central/v/de.viadee.bpm.camunda/external-task-retry-aspect-spring-boot-starter)](https://search.maven.org/artifact/de.viadee.bpm.camunda/external-task-retry-aspect-spring-boot-starter) ![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/viadee/external-task-retry-aspect) -[![](https://img.shields.io/badge/External%20Task%20Handler-7.19.0-orange.svg)](https://docs.camunda.org/manual/7.19/user-guide/ext-client/spring-boot-starter) +[![](https://img.shields.io/badge/External%20Task%20Handler-7.20.0-orange.svg)](https://docs.camunda.org/manual/7.20/user-guide/ext-client/spring-boot-starter) ![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/viadee/external-task-retry-aspect/maven-build.yml) [![](https://img.shields.io/github/issues/viadee/external-task-retry-aspect)](https://github.com/viadee/external-task-retry-aspect/issues) [![](https://img.shields.io/github/stars/viadee/external-task-retry-aspect)](https://github.com/viadee/external-task-retry-aspect/stargazers) @@ -159,6 +159,7 @@ any issue, please feel free to contact me. | 1.5.x | 7.18.0 | 2.7.x | | 1.6.x | 7.19.0 | 2.7.x | | 1.7.x | 7.19.0 | 2.7.x | +| 1.8.x | 7.20.0 | 3.1.x | ## ๐Ÿคน Collaboration This tool was build by viadee Unternehmensberatung AG. If you are interested to find out what @@ -169,10 +170,6 @@ If you have any feedback, ideas or extensions feel free to contact or create a G * Many thanks to [@ChrisSchoe][u_chrisschoe] for making the external-task-retry-aspect spring-boot-3-ready ([#107][i107]) -## ๐Ÿ“ซ Contact - -[![rnschk](https://img.shields.io/twitter/follow/rnschk.svg)](https://twitter.com/rnschk) - ## ๐Ÿ”‘ License [![](https://img.shields.io/github/license/viadee/external-task-retry-aspect)](https://github.com/viadee/external-task-retry-aspect/blob/master/LICENSE) From 7a48b552eac50e13596d64eba9034b58d66b7af5 Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:49:36 +0200 Subject: [PATCH 8/9] Update versions for development branch --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 05ad94c..7cb2204 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ This tool helps to control the retry-behaviour in external-task-handlers based on the official java-client provided by Camunda BPM - 1.7.2-version-updates-SNAPSHOT + 1.7.2-SNAPSHOT 2021 From e097a2429f7b000410fd49e37a039b48b8f81cca Mon Sep 17 00:00:00 2001 From: rnschk <5700718+rnschk@users.noreply.github.com> Date: Fri, 13 Oct 2023 09:50:05 +0200 Subject: [PATCH 9/9] Update versions for release --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7cb2204..dddf25b 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ This tool helps to control the retry-behaviour in external-task-handlers based on the official java-client provided by Camunda BPM - 1.7.2-SNAPSHOT + 1.8.0 2021