Skip to content

Commit

Permalink
safety comments
Browse files Browse the repository at this point in the history
  • Loading branch information
abe-winter committed Apr 16, 2024
1 parent 3fa03d4 commit 5ec7d67
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/check_merge_reqs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Check Requirements for Merge

on:
# note: this workflow does not use secrets and therefore does not check 'safe to test'
pull_request_target:
branches:
- main
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/compile_protos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ env:

jobs:
unlabel:
# unlabel job runs on manual commits only
# This unlabel job runs on manual commits only.
# (because commits generated with GITHUB_TOKEN don't rerun workflow per https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow)
# note: this job doesn't need a 'safe to test' label because it doesn't check out code
runs-on: ubuntu-latest
steps:
- name: remove label
Expand All @@ -47,7 +48,6 @@ jobs:
with:
go-version: '1.21'
# todo: cache download
# todo: make sure there's nothing special about the grpc-web .deb in canon
- name: grpc-web
run: |
wget --quiet https://github.com/grpc/grpc-web/releases/download/${{ env.GRPC_WEB_VERSION }}/protoc-gen-grpc-web-${{ env.GRPC_WEB_VERSION }}-linux-x86_64 -O protoc-gen-grpc-web
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr-labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

jobs:
pr_test_label_manager:
# note: this doesn't check 'safe to test' label because it doesn't check out code
name: PR Test Label Manager
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit 5ec7d67

Please sign in to comment.