Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis auth support in vibe.db.redis.redis.connectRedisDB(...) #1896

Closed
qwertzui11 opened this issue Aug 20, 2017 · 3 comments
Closed

redis auth support in vibe.db.redis.redis.connectRedisDB(...) #1896

qwertzui11 opened this issue Aug 20, 2017 · 3 comments

Comments

@qwertzui11
Copy link

qwertzui11 commented Aug 20, 2017

Hi, great library! thx for your work!

there's an open // TODO: support password at
https://github.com/rejectedsoftware/vibe.d/blob/master/redis/vibe/db/redis/redis.d#L47
that simply could get resolved by replacing the TODO with
cli.auth(url.password);
In my opinion that would improve the usability a lot, eg with heroku and the chat tutorial.

string url = environment.get("REDIS_URL") ~ "/0";
RedisDatabase db = connectRedisDB(URL(url));

What do you think? If want, I can open a pull request.

@s-ludwig
Copy link
Member

That makes sense! There is already a pull request open that addresses this together with a few other possibilities: #1842 - It got a bit lost in the queue, but I'll try to get back to it as soon as possible.

@qwertzui11
Copy link
Author

Thanks a lot, if I can do anything to help you out, let me know! 😃

@wilzbach
Copy link
Member

FYI apart from #1842 there's also the convenience PR for using strings too: #1852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants