This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Add an additional webroot path setting, used by the rev tasks
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sks to generate correct asset URIs when the main `dest` is different from the final public folder.
greypants
suggested changes
Dec 15, 2017
# Conflicts: # README.md # gulpfile.js/tasks/rev/rev-css.js
|
Sorry about that! I went back and forth a couple times on what to name that config option. Just pushed an update making it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my use case of copying template files to a location outside of the public webroot using the
htmltask, I needed a way of adjusting the asset URIs that therevtasks generate – for example ifdestis./distandstylesheets.destispublic/assets/css, I would end up with an entry in rev-manifest.json like"public/assets/css/site.css": "public/assets/css/site-1234567890.css", which obviously wouldn't match against the actual asset URL in my markup.What I did was add an additional
webrootoption topath-config.json. If that is set, it is considered the base path of the final URIs that are stored inrev-manifest.json. Using my example above, I would set"webroot": "public"and end up with"assets/css/site.css": "assets/css/site-1234567890.css".I went back and forth a few times on what to call that new setting (
assetsRoot,rootPath....), so feel free to rename it to whatever you feel is most appropriate if you decide to accept this PR.