Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated Package Content #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Depreciated Package Content #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd6e66
depreciation update
Nov 22, 2016
5a7ad77
package request name change
Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var bunyan = require('bunyan'),
has = require('lodash.has'),
set = require('lodash.set'),
useragent = require('useragent'),
uuid = require('node-uuid'),
uuid = require('uuid'),
util = require('util');


Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "express-bunyan-logger",
"version": "1.3.1",
"version": "1.3.2",
"description": "a bunyan logger middleware for express",
"main": "index.js",
"scripts": {
Expand All @@ -20,7 +20,7 @@
"bunyan": "^1.8.1",
"lodash.has": "^4.5.1",
"lodash.set": "^4.3.1",
"node-uuid": "^1.4.7",
"uuid": "^3.0.0",
"useragent": "^2.1.9"
},
"devDependencies": {
Expand All @@ -42,5 +42,5 @@
"Ognian Tschakalov <[email protected]>",
"Simon Wade <[email protected]>"
],
"license": "BSD"
"license": "BSD-3-Clause"
Copy link
Collaborator

@marcbachmann marcbachmann Dec 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BSD license is the 4-Clause license: https://en.wikipedia.org/wiki/BSD_licenses#4-clause_license_.28original_.22BSD_License.22.29

So we can't just change the license like that. We have to contact @villadora to do that (maybe we can change it to another license right away).

I'll accept a pr with the change to BSD-4-Clause.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably be a good thing for @villadora to weigh in on, especially considering that they are mostly hands off of this lib at this point. The 4-Clause requires attribution (which I doubt most people follow). The 3-Clause is an OSI approved license and would simplify things for users while still maintaining the same licensing protections.

}