feat: disable google_japanese_input on affix conversions #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the
google_japanse_input
source returns invalid candidates for affixes (prefix and suffix).For example,
Dai>
gives第>
and大>
.This PR prevents it by conditionally disabling the
google_japanse_input
source.In order to implement the feature, I changed the signature of
getHenkanResult()
and related methods.Let me know if reviewer prefers
type, word, affix
or some other signatures.