feat: Default baseline file #10696
Merged
feat: Default baseline file #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for PHP 8.0 are failing, but as I understand this version is not supported. |
|
|
Should I point then to master or 5.x? |
weirdan
reviewed
Feb 12, 2024
Either way is good with me. It looks like it picked up unrelated commits from |
jorgsowa
force-pushed
the
default-set-baseline-value-2
branch
from
8fc0059 to
ceaea62
Compare
jorgsowa
force-pushed
the
default-set-baseline-value-2
branch
from
b35bb3f to
95c70d9
Compare
weirdan
requested changes
Feb 13, 2024
weirdan
approved these changes
Feb 13, 2024
weirdan
added
the
release:feature
|
Thanks! |
|
Hey @weirdan! As this was merged to master do you know when a new version of Psalm will be released to include my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5831
This PR sets the default baseline file, so it's not necessary anymore to write commands with the baseline file name like psalm --set-baseline=psalm-baseline.xml.
Precedence of argument:
Continuation of #10592 because of invalid rebase.