-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variadic params should always be optional and fix redundant optional variadic annotation #10777
base: 5.x
Are you sure you want to change the base?
Conversation
kkmuffme
commented
Mar 3, 2024
•
edited
Loading
edited
- fix variadic params have wrong type in PHP 8/8.1
- Fix PHP variadic internal functions should not allow named calls #10787
- add error when using named arguments in PHP <8
- fix report an error in all cases when unpacking string keyed array in PHP < 8.1 in all cases (reported for < 8.0 in some incorrectly)
- fix no errors reported for unpacked union (e.g. array|int)
- fix keyed array with fallback didn't report the same errors as unkeyed array for toomany/toofewarguments
- add error for possibly too many/few arguments with array unpacking
- fix named arguments after positional arguments not reported in unpacking
- fix Inconsistent handling of "empty"-status of arrays as return values #9188
cd6937c
to
d45dc75
Compare
… function returns early
…lls on variadic Fix vimeo#10787
…ly available from PHP 8.1 and no errors reported at all
…mpared to non-keyed array or union
- add error for possibly too many/few arguments with array unpacking - fix named arguments after positional arguments not reported in unpacking
d45dc75
to
4436c1a
Compare
2ba1d63
to
89e9a61
Compare
89e9a61
to
26ed6d8
Compare
26ed6d8
to
03bde5e
Compare
@weirdan review and merge please |
189 new errors reported in PHPUnit look quite worrying: https://app.circleci.com/pipelines/github/vimeo/psalm/13214/workflows/7c12912e-4b6a-4e48-9ba6-06a9d0015c09/jobs/43049 |
Went through them quickly and they're all correct in terms of that we cannot be certain that there's not a bug hidden. |