Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panning #10

Open
devdebonair opened this issue Jun 26, 2016 · 4 comments
Open

Panning #10

devdebonair opened this issue Jun 26, 2016 · 4 comments
Labels

Comments

@devdebonair
Copy link

As of now, you cannot drag the slide menu open. Love the API and it's simplicity, but I would love for there to be an option to drag the menus open instead of an animation kicking off when a swipe on the main view is detected.

@vinnyoodles
Copy link
Owner

Thank you for using this library!

Hmm, I never thought of that. I can definitely add that. In terms of architecture, would you like it to be an either or thing so when the DualSlideController is initialized, you will set it to draggable or slideable? Or would you rather have it contain both drag and slide functions?

I'm asking cause the first solution will be simple in terms of gesture recognition, but the second, definitely doable, would require more gesture handling.

Let me know your thoughts and I can get started on this. It'd be even better if you wanted to submit a pull request for it 😄 .

@devdebonair
Copy link
Author

I believe setting it as slideable or draggable would be the best option. Nice to see how active you are. I am away from my computer for the next couple of days but if you are busy I can submit a pull request when I get some free time.

@vinnyoodles
Copy link
Owner

I would prefer if you could submit a pull request for this and no need to rush it. Thanks!

@devdebonair
Copy link
Author

No problem. I will submit a pull request as soon as I can. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants