Skip to content

Commit

Permalink
remove pointless use of span
Browse files Browse the repository at this point in the history
reread the comments from wwmm and apply common sense
  • Loading branch information
violetmage authored Aug 30, 2024
1 parent f41dac0 commit b3662fd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
6 changes: 2 additions & 4 deletions include/spectrum.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,8 @@ class Spectrum : public PluginBase {
std::array<float, n_bands> real_input;
std::array<double, n_bands / 2U + 1U> output;

std::vector<float> left_delayed_vector;
std::vector<float> right_delayed_vector;
std::span<float, std::dynamic_extent> left_delayed;
std::span<float, std::dynamic_extent> right_delayed;
std::vector<float> left_delayed;
std::vector<float> right_delayed;

std::array<float, n_bands> latest_samples_mono;

Expand Down
9 changes: 2 additions & 7 deletions src/spectrum.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ Spectrum::Spectrum(const std::string& tag,
lv2_wrapper->set_control_port_value("time_l", 1000.0F);
lv2_wrapper->set_control_port_value("time_r", 1000.0F);

left_delayed = std::span<float>(left_delayed_vector);
right_delayed = std::span<float>(right_delayed_vector);



g_signal_connect(settings, "changed::show", G_CALLBACK(+[](GSettings* settings, char* key, gpointer user_data) {
Expand Down Expand Up @@ -111,10 +108,8 @@ void Spectrum::setup() {
std::ranges::fill(real_input, 0.0F);
std::ranges::fill(latest_samples_mono, 0.0F);

left_delayed_vector.resize(n_samples);
right_delayed_vector.resize(n_samples);
std::ranges::fill(left_delayed_vector, 0.0F);
std::ranges::fill(right_delayed_vector, 0.0F);
left_delayed.resize(n_samples, 0.0F);
right_delayed.resize(n_samples, 0.0F);

lv2_wrapper->set_n_samples(n_samples);

Expand Down

0 comments on commit b3662fd

Please sign in to comment.