From b3662fdf0ca1ec686da41c061f92ad489e6a376c Mon Sep 17 00:00:00 2001
From: violetmage <67824960+violetmage@users.noreply.github.com>
Date: Fri, 30 Aug 2024 17:15:25 -0400
Subject: [PATCH] remove pointless use of span

reread the comments from wwmm and apply common sense
---
 include/spectrum.hpp | 6 ++----
 src/spectrum.cpp     | 9 ++-------
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/include/spectrum.hpp b/include/spectrum.hpp
index 6101c8327..d0e5c0d37 100644
--- a/include/spectrum.hpp
+++ b/include/spectrum.hpp
@@ -66,10 +66,8 @@ class Spectrum : public PluginBase {
   std::array<float, n_bands> real_input;
   std::array<double, n_bands / 2U + 1U> output;
   
-  std::vector<float> left_delayed_vector;
-  std::vector<float> right_delayed_vector;
-  std::span<float, std::dynamic_extent> left_delayed;
-  std::span<float, std::dynamic_extent> right_delayed;
+  std::vector<float> left_delayed;
+  std::vector<float> right_delayed;
 
   std::array<float, n_bands> latest_samples_mono;
 
diff --git a/src/spectrum.cpp b/src/spectrum.cpp
index 7026d30d4..f32ed2aaa 100644
--- a/src/spectrum.cpp
+++ b/src/spectrum.cpp
@@ -78,9 +78,6 @@ Spectrum::Spectrum(const std::string& tag,
   lv2_wrapper->set_control_port_value("time_l", 1000.0F);
   lv2_wrapper->set_control_port_value("time_r", 1000.0F);
 
-  left_delayed = std::span<float>(left_delayed_vector);
-  right_delayed = std::span<float>(right_delayed_vector);
-
 
 
   g_signal_connect(settings, "changed::show", G_CALLBACK(+[](GSettings* settings, char* key, gpointer user_data) {
@@ -111,10 +108,8 @@ void Spectrum::setup() {
   std::ranges::fill(real_input, 0.0F);
   std::ranges::fill(latest_samples_mono, 0.0F);
 
-  left_delayed_vector.resize(n_samples);
-  right_delayed_vector.resize(n_samples);
-  std::ranges::fill(left_delayed_vector, 0.0F);
-  std::ranges::fill(right_delayed_vector, 0.0F);
+  left_delayed.resize(n_samples, 0.0F);
+  right_delayed.resize(n_samples, 0.0F);
 
   lv2_wrapper->set_n_samples(n_samples);