clarify why out_path is explicitly dropped

viperML · Aug 26, 2024 · 6eb50ad · 6eb50ad
1 parent 3dc7cdc
commit 6eb50ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/home.rs b/src/home.rs
@@ -151,7 +151,8 @@ impl HomeRebuildArgs {
             .build()?
             .exec()?;
 
-        // Drop the out dir *only* when we are finished
+        // Make sure out_path is not accidentally dropped
+        // https://docs.rs/tempfile/3.12.0/tempfile/index.html#early-drop-pitfall
         drop(out_path);
 
         Ok(())

diff --git a/src/nixos.rs b/src/nixos.rs
@@ -175,7 +175,8 @@ impl OsRebuildArgs {
                 .exec()?;
         }
 
-        // Drop the out dir *only* when we are finished
+        // Make sure out_path is not accidentally dropped
+        // https://docs.rs/tempfile/3.12.0/tempfile/index.html#early-drop-pitfall
         drop(out_path);
 
         Ok(())