Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrement queue size metric on failure #336

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Decrement queue size metric on failure #336

merged 1 commit into from
Nov 24, 2024
+4 −1

Conversation

Robin5605
Copy link
Contributor

This should fix the bug where the queue size metric doesn't properly get decremented on a failure, so over time it slowly increases

@Robin5605 Robin5605 requested review from a team as code owners November 22, 2024 05:58
jonathan-d-zhang
jonathan-d-zhang approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@jonathan-d-zhang jonathan-d-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robin5605 Robin5605 merged commit fa29071 into main Nov 24, 2024
8 checks passed
@Robin5605 Robin5605 deleted the dec-queue-failure branch November 24, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-d-zhang jonathan-d-zhang jonathan-d-zhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robin5605 @jonathan-d-zhang