Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in language UI and transcription languages. Bug fix #21

Merged
merged 53 commits into from
Feb 18, 2025
Merged

Conversation

Odrec
Copy link
Collaborator

@Odrec Odrec commented Jan 28, 2025

lkiesow and others added 27 commits October 7, 2024 15:57
Add ffmpeg debian package to dockerfile
This patch adds a GitHub Actions workflow to automatically build
container images and publish them to the GitHub container registry.
Automatically Publish Container Images
This patch sets sensible default values for some of the configuration
options.
-Disable of streamlit usage statistics
-Increase of max file size upload to 1GB
-Hide developer options from hamburguer menu
-Center media and editor on the screen
-Only show transcription result message when there's an error
-Show srt file as default
-Added several help tooltips
-Limited models to base and large-v3
Several interface and configuration changes.
…rent users using different files with the same name.
Use unique ids to save the output files to avoid conflicts with diffe…
Add missing screenshot
Changes in tooltips text to make them more on point.
Add logo .ico to browser tab
We are removing YouTube support for transcriptions due to known issues in the yt-dlp package with YouTube such as bot confirmations and ip blocks.
…ction's name switched to a string variable halfway through the code
@Odrec Odrec requested a review from dennis531 January 28, 2025 16:30
@Odrec Odrec changed the title Changes in language UI and transcription languages Changes in language UI and transcription languages. Bug fix Jan 28, 2025
@Odrec
Copy link
Collaborator Author

Odrec commented Feb 5, 2025

@dennis531 I had to do some relatively significant changes to the code to keep the file from disappearing when changing language of the UI because of the limitations of the upload file widget from streamlit.

I also realized there were some big files commited at some point so I deleted them which created the need to rebase the main branch and had to resolve some conflicts as a result. But I think now it should work. Can you test it and tell me what you think.

@dennis531
Copy link
Collaborator

Only German translations work, and only if I don't change the language:

Screencast.from.2025-02-05.18-20-24.webm

@Odrec
Copy link
Collaborator Author

Odrec commented Feb 6, 2025

Only German translations work, and only if I don't change the language:

Screencast.from.2025-02-05.18-20-24.webm

I realize I didn't upgrade the whisperx API server. The server was updated to accept the new list of languages so that's why it didn't work. It should be working now.

@dennis531
Copy link
Collaborator

Could you implement that the language does not change to Arabic when the UI language is changed?

…ge. Got rid of the widget form in the sidepanel to facilitate this behavior.
@Odrec
Copy link
Collaborator Author

Odrec commented Feb 12, 2025

Could you implement that the language does not change to Arabic when the UI language is changed?

I had to change the widgets on the side panel to facilitate this behavior but it should be working fine now. Can you please test it when you have time?

@dennis531
Copy link
Collaborator

It works now but I found a new bug. The "Redo Transcription" action doesn't update the textbox with the transcriptions, see video.

Screencast.from.2025-02-13.09-24-30.webm

…e text editor to update with the new transcription. Got rid of some unnecessary session variables.
@Odrec
Copy link
Collaborator Author

Odrec commented Feb 13, 2025

It works now but I found a new bug. The "Redo Transcription" action doesn't update the textbox with the transcriptions, see video.

Screencast.from.2025-02-13.09-24-30.webm

Ok, this should be fixed now.

@Odrec Odrec merged commit be2aee8 into main Feb 18, 2025
1 check passed
@Odrec Odrec deleted the language branch February 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants