Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early return in release #201

Closed
olanod opened this issue Feb 24, 2022 · 1 comment · Fixed by #198
Closed

Early return in release #201

olanod opened this issue Feb 24, 2022 · 1 comment · Fixed by #198
Assignees
@stanly-johnson
Labels
payments payments pallet

Comments

@olanod
Copy link
Member

olanod commented Feb 24, 2022

Checking the release code, should we handle the None returning early to avoid calling settle_payment that reads the storage again?
@olanod olanod added the payments payments pallet label Feb 24, 2022
@stanly-johnson
Copy link
Member

It doesn't increase the read count since its same extrinsic, but removed it in #198 since it makes the code more concise.

@stanly-johnson stanly-johnson linked a pull request Feb 25, 2022 that will close this issue
Cancel RefundRequested transactions #198
Merged
@olanod olanod closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanly-johnson stanly-johnson

Labels
payments payments pallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cancel RefundRequested transactions virto-network/kreivo
2 participants
@olanod @stanly-johnson