Feat/register flow #4
Open
+1,065
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or buttons, add last steps and todo's
…closes if the button label y Cancel or Close
This was
linked to
issues
Dec 4, 2024
olanod
reviewed
Jan 15, 2025
dialog.js
Outdated
| this.animateStepTransition(direction, () => { | ||
| this.currentStep = nextStep; | ||
| this.updateStepContent(); | ||
| customElements.whenDefined('wa-dialog').then(() => { |
There was a problem hiding this comment.
What about using a top level await and define our components only after the wa-dialog is defined? that way you avoid declaring the other functions async
olanod
reviewed
Jan 15, 2025
index.html
Outdated
| </dialog-virto> | ||
|
|
||
|
|
||
| <dialog-virto id="dialog"> |
There was a problem hiding this comment.
we shouldn't need multiple dialogs for each step of the login process 🤔 also id should be unique for any one element in the document
…dialog as needed according to its register/login setup requires
This was
linked to
issues
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.