From 64998e4b1f4523e0bc2a2ea7b5c9a76a1213a5a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ail=C3=A9n=20Grimaldi?= <63558201+ail3ngrimaldi@users.noreply.github.com> Date: Thu, 31 Oct 2024 14:27:29 -0300 Subject: [PATCH] Removes hardcoded 'Wallet' from match (#164) * Removes hardcoded 'Wallet' from match * Modify pattern with two unique options * replace match for let else --- src/components/molecules/actions/members.rs | 17 +++++++++-------- src/components/molecules/onboarding/invite.rs | 17 +++++++++-------- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/src/components/molecules/actions/members.rs b/src/components/molecules/actions/members.rs index da5c98e..e79a1fb 100644 --- a/src/components/molecules/actions/members.rs +++ b/src/components/molecules/actions/members.rs @@ -49,14 +49,15 @@ pub fn MembersAction(props: VotingProps) -> Element { } }, on_change: move |event: ComboInputValue| { - let medium = match event.option { - ComboInputOption::Dropdown(value) => { - match value.key.as_str() { - "Wallet" => MediumOptions::Wallet, - _ => todo!() - } - }, - _ => todo!() + let ComboInputOption::Dropdown(value) = event.option else { + return; + }; + + let invite_wallet = translate!(i18, "onboard.invite.form.wallet.label"); + let medium = if value.key == invite_wallet { + MediumOptions::Wallet + } else { + return; }; if let ActionItem::AddMembers(ref mut meta) = initiative.get_action(props.index) { meta.members[index_meta] = MemberItem { medium, account: event.input }; diff --git a/src/components/molecules/onboarding/invite.rs b/src/components/molecules/onboarding/invite.rs index a84fb8d..2a12898 100644 --- a/src/components/molecules/onboarding/invite.rs +++ b/src/components/molecules/onboarding/invite.rs @@ -59,14 +59,15 @@ pub fn OnboardingInvite() -> Element { MediumOptions::Wallet => translate!(i18, "onboard.invite.form.wallet.placeholder"), }, on_change: move |event: ComboInputValue| { - let medium = match event.option { - ComboInputOption::Dropdown(value) => { - match value.key.as_str() { - "Wallet" => MediumOptions::Wallet, - _ => todo!() - } - }, - _ => todo!() + let ComboInputOption::Dropdown(value) = event.option else { + return; + }; + + let invite_wallet = translate!(i18, "onboard.invite.form.wallet.label"); + let medium = if value.key == invite_wallet { + MediumOptions::Wallet + } else { + return; }; onboard.update_invitation(index, InvitationItem { medium, account: event.input });