Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter #14

Open
semisight opened this issue Apr 28, 2023 · 1 comment

Comments

@semisight
Copy link

When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter.

@wjlee-visenze
Copy link
Contributor

Hi @semisight, apologies for leaving the issue open for so long.

We have had a few version updates since then, the latest commit includes the EncodeUriComponent changes as suggested. Could you check it again?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants