Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the scss/dollar-variable-colon-space-after rule already present in stylelint-config-standard-scss #59

Merged
merged 1 commit into from
May 6, 2024
Merged

Drop the scss/dollar-variable-colon-space-after rule already present in stylelint-config-standard-scss #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions scss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ module.exports = {
extends: 'stylelint-config-standard-scss',
rules: {

// Disable ESlint as we intentionally break alphabetical order rule here.
/* eslint-disable sort-keys */
/* eslint-disable sort-keys -- We need to set CSS rules before SCSS rules. */

// Turn `comment-no-empty` back on for empty CSS comments since `scss/comment-no-empty` is turned off later on:
// Restore `comment-no-empty` of `stylelint-config-standard-scss` as per `stylelint-config-recommended`.
// https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/comment-no-empty/README.md
'comment-no-empty': true,

Expand All @@ -32,7 +31,6 @@ module.exports = {
},
],
'scss/comment-no-empty': null, // Allow empty lines in structured block comments.
'scss/dollar-variable-colon-space-after': 'always-single-line', // Support multi-line variable definitions.
'scss/dollar-variable-empty-line-before': null, // Turn off to support grouping variables using empty lines.
'scss/dollar-variable-pattern': [ // Prefer _ over - for private variables.
'^(_?[a-z][a-z0-9]*)(-[a-z0-9]+)*$',
Expand Down