From 1113beca338a5c10a47a2733b60c5598d05efee1 Mon Sep 17 00:00:00 2001 From: Kathleen Biagas Date: Mon, 23 Dec 2024 11:46:31 -0800 Subject: [PATCH] Fix logging query pick global element (#20156) * Fix how use_global_id query parameter is retrieved. This resolves #20138, logging of Pick query incorrect when using global id. * Add release notes for 3.5.0. Added this bugfix and a few more of my changes. --- src/resources/help/en_US/relnotes3.5.0.html | 113 ++++++++++++++++++++ src/visitpy/common/Logging.C | 8 +- 2 files changed, 117 insertions(+), 4 deletions(-) create mode 100644 src/resources/help/en_US/relnotes3.5.0.html diff --git a/src/resources/help/en_US/relnotes3.5.0.html b/src/resources/help/en_US/relnotes3.5.0.html new file mode 100644 index 0000000000..5566c8bb12 --- /dev/null +++ b/src/resources/help/en_US/relnotes3.5.0.html @@ -0,0 +1,113 @@ + + + + + + + + VisIt 3.5 Release Notes + + + + +
VisIt 3.5 Release Notes
+ +

Welcome to VisIt's release notes page. This page describes the important +enhancements and bug-fixes that were added to this release.

+ +

Sections

+ + + +

General features added in version 3.5

+ + + +

Advanced features added in version 3.5

+ + + +

Changes in GUI behavior for version 3.5

+ + + +

File format reader changes in version 3.5

+ + + +

Changes to VisIt's plots in version 3.5

+ + + +

Changes to VisIt's operators in version 3.5

+ + + +

Changes to VisIt's expression language in version 3.5

+ + + +

Changes to VisIt's picks and queries in version 3.5

+ + + +

Other bugs fixed in version 3.5

+ + + +

Changes to build_visit in version 3.5

+ + + +

Changes for VisIt developers in version 3.5

+ + +

Click the following link to view the release notes for the previous version +of VisIt: 3.4.2.

+ + diff --git a/src/visitpy/common/Logging.C b/src/visitpy/common/Logging.C index e3903e7442..12028b49de 100644 --- a/src/visitpy/common/Logging.C +++ b/src/visitpy/common/Logging.C @@ -1356,9 +1356,9 @@ static std::string log_QueryRPC(ViewerRPC *rpc) qn = "NodePick"; else if (pt == "DomainZone") { - bool global = false; + int global = 0; if (queryParams.HasNumericEntry("use_global_id")) - global = queryParams.GetEntry("use_global_id")->ToBool(); + global = queryParams.GetEntry("use_global_id")->ToInt(); if (global) qn = "PickByGlobalZone"; else @@ -1366,9 +1366,9 @@ static std::string log_QueryRPC(ViewerRPC *rpc) } else if (pt == "DomainNode") { - bool global = false; + int global = 0; if (queryParams.HasNumericEntry("use_global_id")) - global = queryParams.GetEntry("use_global_id")->AsBool(); + global = queryParams.GetEntry("use_global_id")->AsInt(); if (global) qn = "PickByGlobalNode"; else