Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GuessCycle() and friends to StringHelpers #20100

Open
markcmiller86 opened this issue Dec 2, 2024 · 0 comments
Open

Move GuessCycle() and friends to StringHelpers #20100

markcmiller86 opened this issue Dec 2, 2024 · 0 comments
Assignees
@markcmiller86
Labels
enhancement New feature or request impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work reviewed Issue has been reviewed and labeled by a developer
Milestone
3.5.0

Comments

@markcmiller86
Copy link
Member

markcmiller86 commented Dec 2, 2024 •
edited
Loading

We have logic for guessing cycles from filenames in avtFileFormat.[Ch]. There is no reason it needs to be there. It is all string processing and is probably best re-factored to src/common/utility/StringHelpers.[Ch]. Its better there because StringHelpers is more easily included in more places in VisIt.
@markcmiller86 markcmiller86 added enhancement New feature or request impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work labels Dec 2, 2024
@markcmiller86 markcmiller86 added this to the 3.4.3 milestone Dec 2, 2024
@markcmiller86 markcmiller86 self-assigned this Dec 2, 2024
@JustinPrivitera JustinPrivitera added the reviewed Issue has been reviewed and labeled by a developer label Feb 11, 2025
@JustinPrivitera JustinPrivitera modified the milestones: 3.4.3, 3.5.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markcmiller86 markcmiller86

Labels
enhancement New feature or request impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work reviewed Issue has been reviewed and labeled by a developer
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@markcmiller86 @JustinPrivitera