Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudocolor plot of mixed-material variable stored in Blueprint is SLOW. #20114

Open
BradWhitlock opened this issue Dec 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood

Comments

@BradWhitlock
Copy link
Member

Describe the bug

Plotting a mixed-material variable stored in Blueprint is slow. I made a mesh with 1M quads, 3 materials, and a mixed-material variable. When I made a plot of the variable, it took a long time for the engine to execute the plot.

I killed the engine and got a stack and it looks like the to_silo() method in Conduit (which turns the mixed-material field to Silo format) is likely what is taking the time. I skimmed that code the other day and it appeared to do a lot of Node data conversion, which is known to be slow.

4       0x1555238b4618 avtBlueprintFileFormat::GetVar(int, char const*) + 3000
3       0x15554ac5518a conduit::blueprint::mesh::matset::detail::to_silo(conduit::Node const&, conduit::Node const&, conduit::Node&, double) + 1530
2       0x15554b01b26c conduit::Node::Node(conduit::Node const&) + 44
1       0x15554b018759 conduit::Node::compact_to(conduit::Node&) const + 73

To Reproduce

  1. Open blueprint_final.root
  2. Add a Pseudocolor plot of mesh_main/mass
  3. Draw

Expected behavior

The plot should be generated a lot faster (no more than a few seconds). It's taking minutes.

Attachments

The data file was given on RZ to @cyrush , @JustinPrivitera in case that is helpful.

Desktop

  • rzwhippet
@BradWhitlock BradWhitlock added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Dec 7, 2024
@cyrush
Copy link
Member

cyrush commented Dec 9, 2024

@BradWhitlock thanks for the example, we will take a look

@JustinPrivitera
Copy link
Member

to_silo in Conduit could probably use lots of love.

@JustinPrivitera JustinPrivitera self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood
Projects
None yet
Development

No branches or pull requests

3 participants