Add configurable elasticsearch port #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable to configure an alternate elasticsearch port (for example, AWS elasticsearch).
I was forced to choose the variable
ELASTICSEARCH_TCP_PORTinstead ofELASTICSEARCH_PORT(which would make more sense), because Docker already exposes that variable when linking a container, albeit unusable to us since it exposestcp://elasticsearch:9200.Another alternative would be to parse the variable that docker exposes (which contains
tcp://elasticsearch:9200) and retrieve the port from there. That approach isn't very useful for users who are running this container using extra_hosts, for example:docker run --add-host "elasticsearch:<ip>" visity/elasticsearch-curator