Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrEIA.modules.Split incorrect completion of missing dimension when initialized with section_sizes Sequence #152

Open
RussellALA opened this issue Feb 28, 2023 · 0 comments

Comments

@RussellALA
Copy link
Collaborator

When initializing the FrEIA.modules.Split module as follows:

dim_in = (10,)
split_dims = (4, 3)
m = Split(dim_in, split_dims)

We get m.split_size_or_sections == None
Expected behaviour: m.split_size_or_sections == (4, 3, 3)
Suggested fix:
Change l.70 of modules/graph_topology.py from section_sizes = list(section_sizes).append(l_dim - sum(section_sizes)) to section_sizes = list(section_sizes) + [l_dim - sum(section_sizes)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant